From 46b332fb63bb33caf80743d43eae948f0a18cab2 Mon Sep 17 00:00:00 2001
From: Annavar Satish <112172196+Annavar-satish@users.noreply.github.com>
Date: Thu, 6 Jul 2023 07:24:36 +0530
Subject: [PATCH] fixed the healthcheck probes taking twice (#44)

* fixed the healthcheck probes taking twice

* update version

* updated the healthcheck type condition
---
 charts/polymorphic-app/Chart.yaml             | 2 +-
 charts/polymorphic-app/templates/service.yaml | 3 +--
 charts/polymorphic-app/values.yaml            | 4 ++--
 3 files changed, 4 insertions(+), 5 deletions(-)

diff --git a/charts/polymorphic-app/Chart.yaml b/charts/polymorphic-app/Chart.yaml
index 8e2526e..85d8858 100644
--- a/charts/polymorphic-app/Chart.yaml
+++ b/charts/polymorphic-app/Chart.yaml
@@ -4,5 +4,5 @@ description: A Helm chart for deploying any custom applications, specifically po
 maintainers:
   - name: improwised
 type: application
-version: 1.2.3
+version: 1.2.4
 appVersion: 1.0.0
diff --git a/charts/polymorphic-app/templates/service.yaml b/charts/polymorphic-app/templates/service.yaml
index e756285..1c190ed 100644
--- a/charts/polymorphic-app/templates/service.yaml
+++ b/charts/polymorphic-app/templates/service.yaml
@@ -138,8 +138,7 @@ spec:
             timeoutSeconds: 7
             initialDelaySeconds: {{ .healthcheck.initialDelaySeconds | default $.Values.serviceTemplate.healthcheck.initialDelaySeconds | default "20" }}
             periodSeconds: {{ .healthcheck.periodSeconds | default $.Values.serviceTemplate.healthcheck.periodSeconds | default "20" }}            
-          {{- end }}
-          {{- if and (or (eq .healthcheck.type "tcpSocket") (eq $.Values.serviceTemplate.healthcheck.type "tcpSocket")) (or .healthcheck.port $.Values.serviceTemplate.healthcheck.port) }}
+          {{- else if and (or (eq .healthcheck.type "tcpSocket") (eq $.Values.serviceTemplate.healthcheck.type "tcpSocket")) (or .healthcheck.port $.Values.serviceTemplate.healthcheck.port) }}
           livenessProbe:
             tcpSocket:
               port: {{ .healthcheck.port | default $.Values.serviceTemplate.healthcheck.port }}
diff --git a/charts/polymorphic-app/values.yaml b/charts/polymorphic-app/values.yaml
index a915d54..10edadd 100644
--- a/charts/polymorphic-app/values.yaml
+++ b/charts/polymorphic-app/values.yaml
@@ -36,8 +36,8 @@ serviceTemplate:
   healthcheck:
     enabled: false
     type: httpGet
-    path: /healthz
-    port: http
+    # path: /healthz
+    # port: http
     # initialDelaySeconds: 30
     # periodSeconds: 30